-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added initial Trimming support. #21
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! The core fixes look good! I just have a question and a change request I commented inline in the sources.
@HavenDV @KrzysztofCwalina any chance we could revive this PR and merge it in? would be super useful to get NAOT support (plus source generated JSON parsing would likely be more efficient than reflection) |
Once you remove the trimming helper, I can unblock this PR. |
# Conflicts: # OpenAI.sln # src/Custom/Common/InternalListHelpers.cs # src/Custom/OpenAIModelFactory.cs # src/OpenAI.csproj
It has been removed |
Closes #20
But because preview version of System.Memory.Data does not explicitly support net6.0, this warning appears hereThere are two ways out:Ignore, this can work without problemsAdd #ifdef/ MSBuild Conditions to use old behavior for net6 and new for net8/netstandardI'm waiting for feedback