[Bugfix]: Change env CHROMA_IN_MEMORY's type from str to bool before use it #402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description*: In
chroma_datastore.py
, the os.getenv function returns the value of theCHROMA_IN_MEMORY
environment variable as a string. Currently, in theChromaDataStore.__init__
method (specifically, thein_memory
variable), it directly relies on this value for decision-making(e.g.:if in_memory: ...
). However, since any non-empty string is evaluated asTrue
in theif
statement, it results in the program attempting to use in_memory storage even when the CHROMA_IN_MEMORY environment variable is set to "false".Issue(s) Linked: #401