Support updating submodules to main branch #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 31, 2024
TarSCM/scm/git.py
Outdated
| @@ -201,7 +201,7 @@ def fetch_submodules(self): | |||
| '--recursive'], | |||
| cwd=self.clone_dir | |||
| ) | |||
| elif 'submodules' in argsd and argsd['submodules'] == 'master': | |||
| elif 'submodules' in argsd and argsd['submodules'] in [ 'main', 'master' ]: | |||
There was a problem hiding this comment.
line too long (83 > 79 characters)
whitespace after '['
whitespace before ']'
adrianschroeter
force-pushed
the
main_branch_update
branch
from
e7521af to
5b09df7
Compare
houndci-bot
reviewed
Jul 31, 2024
| @@ -201,7 +201,8 @@ def fetch_submodules(self): | |||
| '--recursive'], | |||
| cwd=self.clone_dir | |||
| ) | |||
| elif 'submodules' in argsd and argsd['submodules'] == 'master': | |||
| elif 'submodules' in argsd and | |||
| argsd['submodules'] in ['main', 'master']: | |||
There was a problem hiding this comment.
indentation is not a multiple of four
unexpected indentation
adrianschroeter
force-pushed
the
main_branch_update
branch
2 times, most recently
from
ed43621 to
cb1d272
Compare
houndci-bot
reviewed
Jul 31, 2024
TarSCM/scm/git.py
Outdated
| @@ -201,7 +201,8 @@ def fetch_submodules(self): | |||
| '--recursive'], | |||
| cwd=self.clone_dir | |||
| ) | |||
| elif 'submodules' in argsd and argsd['submodules'] == 'master': | |||
| elif 'submodules' in argsd and \ | |||
| argsd['submodules'] in ['main', 'master']: | |||
There was a problem hiding this comment.
continuation line over-indented for visual indent
main is the new master ... even better would be a possibility to specify the branch or tag. Maybe with tag:<SOMTHING>, but then the next question arises to do this per submodule ...
adrianschroeter
force-pushed
the
main_branch_update
branch
from
cb1d272 to
1429ea9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main is the new master ... even better would be a
possibility to specify the branch or tag. Maybe with tag:, but then the next question arises
to do this per submodule ...