Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect cluster ingress in helm2 #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maire-kehoe
Copy link
Contributor

@maire-kehoe maire-kehoe commented Nov 12, 2020

In the helm2 script check_and_deploy_helm.sh,
for clusters that have disabled NodePort but that do have cluster ingress enabled,
detect and update a Kubernetes Ingress resource with values reflecting the cluster ingress configuration.

Roughly, the steps are
if the Helm chart values has: ingress
then set: ingress.enabled=true
and replace chart strings cluster-ingress-subdomain and cluster-ingress-secret
with the respective cluster ingress host and cluster ingress secret.
That is, for each host at a path like ingress.hosts[0]
that has a value like "hello-app.cluster-ingress-subdomain",
change it to a value like "hello-app.example.com".
For each tls host at a path like ingress.tls[0].hosts[0]
that has a value like "hello-app.cluster-ingress-subdomain",
change it to a value like "hello-app.example.com".
For each tls secret at a path like ingress.tls[0].secretName
that has a value like "cluster-ingress-secret",
change it to a value like "example-tls-secret".

Related to the proposed changes in the hello-helm repo:

Also related to the similar previous change for non-Helm kubectl deploys:

@maire-kehoe maire-kehoe requested a review from huayuenh November 12, 2020 17:35
@maire-kehoe
Copy link
Contributor Author

Note this code needs updates similar to:

@maire-kehoe
Copy link
Contributor Author

Likewise need fix: #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant