-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for surf HTTP client #1537
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1537 +/- ##
=======================================
+ Coverage 65.5% 65.8% +0.2%
=======================================
Files 140 140
Lines 19569 19488 -81
=======================================
Hits 12824 12824
+ Misses 6745 6664 -81 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Small ask on the Changelog, call it out as breaking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
Also towards #1427 (comment) |
Good to merge once merge conflicts resolved, and the changelog calls out breaking change! Thanks @djc |
e752d7d
to
c519c11
Compare
Rebased. How do you all feel about pushing out a release once this is merged? IMO it would be quite helpful to get the bumped tonic/prost dependencies out there given that they were severely lagging at this point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all these cleanups
Changes
In a similar vein as #1534 / #1524, surf has seen its last release over 2 years ago and by the admission of its maintainer is pretty much unmaintained. On crates.io, it got 166k downloads in the last three months, vs reqwest's 11.7M.
#1534
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes