Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: remove the grpcio gRPC backend #1524

Closed
djc opened this issue Feb 12, 2024 · 1 comment · Fixed by #1534
Closed

[Feature]: remove the grpcio gRPC backend #1524

djc opened this issue Feb 12, 2024 · 1 comment · Fixed by #1534
Labels
A-common Area:common issues that not related to specific pillar triage:accepted Has been triaged and accepted.

Comments

@djc
Copy link
Contributor

djc commented Feb 12, 2024

Related Problems?

No response

Describe the solution you'd like:

The grpcio crate seems to be mostly used for internal TiKV purposes, and as a result doesn't get much maintenance. While it finally gained an option to use prost as a codec, apparently its prost update has gotten stuck for six months, making an upgrade to prost 0.12 and recent tonic harder. Given the amount of maintenance this project's dependencies are getting and given the limited popularity of the grpcio implementation (50k downloads in past 90 days vs 7.9M for tonic in the same time frame), I propose we remove the grpcio implementation from the opentelemetry core crates.

I would be willing to do the legwork if necessary.

Considered Alternatives

Alternatively, maybe there is some way to cut the grpcio dependencies off from the other crates in a way that it doesn't block tonic work? But if none of the maintainers is willing to champion doing the work to keep grpcio going, I think removing support for it is the better choice.

Additional Context

No response

@djc djc added enhancement New feature or request triage:todo Needs to be traiged. labels Feb 12, 2024
@cijothomas
Copy link
Member

Thanks for opening this. I agree, removing grpcio support is the right move.

Could you send PR(s) with the changes?

@cijothomas cijothomas added A-common Area:common issues that not related to specific pillar triage:accepted Has been triaged and accepted. and removed enhancement New feature or request triage:todo Needs to be traiged. labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-common Area:common issues that not related to specific pillar triage:accepted Has been triaged and accepted.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants