Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic periodic exporting metric_reader #1603
feat: add basic periodic exporting metric_reader #1603
Changes from 17 commits
32a6582
3566cd2
cb84455
0ecb543
3731304
2aef8bf
8e90ebb
23d9a1f
02055b7
2d31c72
512f959
da09c44
ed9029c
63405d5
9fad788
2662097
4fd4e2f
81edbc5
cfa4974
0cb373c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also pass
timeout: @export_timeout
to the@exporter
?Same as here
opentelemetry-ruby/sdk/lib/opentelemetry/sdk/trace/export/batch_span_processor.rb
Line 188 in 5172e84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
Timeout.timeout(@export_timeout) { ... }
will serve the purpose of timeout exporter if the exporter doesn't behave correctly (e.g. hanging).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I was just saying maybe we should pass the timeout also to the exporter to give it a chance to behave properly. We still keep the surrounding
Timeout.timeout(@export_timeout) { ... }
blockThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. I have updated the part that pass timeout to exporter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
OpenTelemetry.handle_error(exception: e, message: 'PeriodicMetricReader timeout.')
evaluating toFAILURE
? if not then we should returnFAILURE
explicitly here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think metric_reader shouldn't return anything (similar to metric_reader); only exporter will return either fail or success from export
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, you are absolutely right.