[DO NOT MERGE] Prototype Entities (otep#264) in Java SDK #6855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does NOT update Resource.merge for entities yet. This has many inefficiencies that can be optimised away. - Adds Entity + EntityBuilder for constructing entities in the SDK - Add EntityDetector for discovering entities - Moves `service` and `telemetry.sdk` detection to EntityDetectors - Updates to semconv 1.28.0 for service/telemetry.sdk - Updates Resource + ResourceBuilder to preserve Entity - Creates a ResourceProvider that can be used to construct Resource using entity merge rules. - Hacky `getAttributes` update on Resource to preserve existing behavior. Tests pending.
jsuereth
force-pushed
the
wip-resource-updates
branch
from
4d81df2
to
b7421c2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6855 +/- ##
============================================
- Coverage 90.28% 90.16% -0.12%
- Complexity 6588 6640 +52
============================================
Files 729 736 +7
Lines 19768 19945 +177
Branches 1944 1964 +20
============================================
+ Hits 17847 17984 +137
- Misses 1327 1362 +35
- Partials 594 599 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype of Java SDK updates for Entities OTEP.
Entity,EntityBuilder,EntityDetectorto sdk common package.ResourceandResourceBuilder. Updates merge logic to match OTEP specification.ResourceProviderwhich attempts to centralize Resource/Entity logic. This will need to be sorted out with existing sdk-extension ResourceProviders.toStringchanges.Note: This prototype does NOT attempt to isolate experimental features into
internaldirectories and expose an experimental package. That would be done when fragmenting this prototype into components and submitting "final" variants w/ specification work.