-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend prometheus declarative config support to include without_scope_info, with_resource_constant_labels #6840
base: main
Are you sure you want to change the base?
Conversation
…_info, with_resource_constant_labels
* <p>This class is internal and is hence not for public use. Its APIs are unstable and can change | ||
* at any time. | ||
*/ | ||
public final class IncludeExcludePredicate implements Predicate<String> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a recurring pattern of needing to match strings against a configurable allow / deny list, with optional glob pattern matching. In all these cases, its beneficial to have a useful toString()
implementation.
This PR refactors the places this pattern occurs with a common implementation.
joiner.add( | ||
"defaultAggregationSelector=" | ||
+ DefaultAggregationSelector.asString(defaultAggregationSelector)); | ||
return joiner.toString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR also improves the PrometheusHttpServer#toString()
implementation, which has been failing to include the various configurable parameters.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6840 +/- ##
============================================
+ Coverage 90.49% 90.53% +0.03%
- Complexity 6598 6611 +13
============================================
Files 731 732 +1
Lines 19735 19762 +27
Branches 1938 1948 +10
============================================
+ Hits 17860 17891 +31
+ Misses 1283 1277 -6
- Partials 592 594 +2 ☔ View full report in Codecov by Sentry. |
From the schema: https://github.com/open-telemetry/opentelemetry-configuration/blob/e196026e6779e180155537f0e7585a379b40a1d3/examples/kitchen-sink.yaml#L93-L108