Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add junit instrumentation (#8953) #11505

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aschugunov
Copy link
Contributor

@aschugunov aschugunov commented May 31, 2024

Снимок экрана 2024-05-31 в 14 55 45
It is a draft for getting opinions and feedbacks

@aschugunov aschugunov requested a review from a team May 31, 2024 11:55
@github-actions github-actions bot requested a review from theletterf May 31, 2024 11:55
@aschugunov aschugunov marked this pull request as draft May 31, 2024 11:58
@jeanbisutti
Copy link
Member

@aschugunov

It seems great!

The feature may make more sense in the JUnit 5 repository, where it would be more visible to the JUnit 5 users. JUnit 5 has a JFR support. The Junit 5 team may also be interested in an OpenTelemetrty one.

Alternatively, the feature could be hosted in the opentelemetry-java-contrib repository.

@trask
Copy link
Member

trask commented Jun 4, 2024

hi @aschugunov!

check out the CI/CD semantic convention SIG: https://github.com/open-telemetry/community/blob/main/projects/ci-cd.md

and some of their initial work, e.g. open-telemetry/semantic-conventions#915

I think we'd likely accept the contribution into this repository if it follows and supports the OpenTelemetry CI/CD semantic convention effort

cc @adrielp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants