Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templatize the otelhttp semconv module #6626

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

dmathieu
Copy link
Member

So it can be reused by other instrumentation packages.

Closes #5790

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jan 16, 2025
@dmathieu dmathieu marked this pull request as ready for review January 16, 2025 09:04
@dmathieu dmathieu requested a review from a team as a code owner January 16, 2025 09:04
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.6%. Comparing base (df8e435) to head (d9ef596).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6626     +/-   ##
=======================================
- Coverage   68.6%   68.6%   -0.1%     
=======================================
  Files        200     200             
  Lines      16872   16872             
=======================================
- Hits       11585   11582      -3     
- Misses      4939    4941      +2     
- Partials     348     349      +1     
Files with missing lines Coverage Δ
...entation/net/http/otelhttp/internal/semconv/env.go 93.3% <ø> (ø)
...ion/net/http/otelhttp/internal/semconv/httpconv.go 87.0% <ø> (ø)
...ntation/net/http/otelhttp/internal/semconv/util.go 89.4% <ø> (ø)
...tion/net/http/otelhttp/internal/semconv/v1.20.0.go 93.6% <ø> (ø)

... and 1 file with indirect coverage changes

@dmathieu dmathieu merged commit dafdad1 into open-telemetry:main Jan 17, 2025
26 checks passed
@dmathieu dmathieu deleted the templatize-semconv branch January 17, 2025 09:08
@MrAlias MrAlias added this to the v1.34.0 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
Development

Successfully merging this pull request may close these issues.

Template semconv changes in otelhttp
5 participants