-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cowboy SemConv 1.27.0 #359
Merged
bryannaegele
merged 18 commits into
open-telemetry:main
from
bryannaegele:cowboy-1.25-semconv
Oct 15, 2024
Merged
Cowboy SemConv 1.27.0 #359
bryannaegele
merged 18 commits into
open-telemetry:main
from
bryannaegele:cowboy-1.25-semconv
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregMefford
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a few small things I noticed.
instrumentation/opentelemetry_cowboy/src/opentelemetry_cowboy.erl
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry_cowboy/src/opentelemetry_cowboy.erl
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry_cowboy/src/opentelemetry_cowboy.erl
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry_cowboy/src/opentelemetry_cowboy.erl
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry_cowboy/src/opentelemetry_cowboy.erl
Outdated
Show resolved
Hide resolved
bryannaegele
force-pushed
the
cowboy-1.25-semconv
branch
from
October 9, 2024 02:18
4e557b2
to
dbf7274
Compare
GregMefford
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to merge.
Merged
Co-authored-by: Greg Mefford <[email protected]>
Co-authored-by: Greg Mefford <[email protected]>
Co-authored-by: Greg Mefford <[email protected]>
Co-authored-by: Greg Mefford <[email protected]>
Co-authored-by: Greg Mefford <[email protected]>
bryannaegele
force-pushed
the
cowboy-1.25-semconv
branch
from
October 15, 2024 22:14
09c4a07
to
a7786dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SemConv 1.26 compatibility.
This also introduces the equivalent of Go's public endpoint functionality to let users decide when a request should be processed as internal or external.
This introduces a large number of breaking changes from the evolution of the spec since 1.17 and 1.20. Given the stability of the library over time to date and the need to version to a breaking number, we'll set this to 1.0.0 to force users to manually bump the version.
Addresses #183 for cowboy
Resolves #361
Relies on open-telemetry/opentelemetry-erlang#733 and #358