Tesla: Include span attributes on error #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The call to `Tesla.run` could possibly return `{:error, _}` in certain
cases (ex. timeout). Since attributes were set in a step after this,
they were skipped in these scenarios.
This sets the attributes before the call to `Tesla.run` and then again
after to cover the scenario that a middleware modified the attributes
and they have been updated on the `Env`.
jeffutter
force-pushed
the
tesla-include-attributes-on-error
branch
from
01c2146
to
1b48e18
Compare
| } = env | ||
| ) do | ||
| attrs = | ||
| Map.merge(build_base_attrs(env), %{ |
There was a problem hiding this comment.
What's the reasoning to replace all the attributes created during the request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
Tesla.runcould possibly return{:error, _}in certain cases (ex. timeout). Since attributes were set in a step after this, they were skipped in these scenarios.This sets the attributes before the call to
Tesla.runand then again after to cover the scenario that a middleware modified the attributes and they have been updated on theEnv.