Allow to configure which headers should be used as span attrs #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Pls update the CHANGELOG tho :) |
tsloughter
reviewed
Jul 9, 2023
instrumentation/opentelemetry_cowboy/src/opentelemetry_cowboy.erl
Outdated
Show resolved
Hide resolved
|
Marked as draft since it need #186 to be merged before proceeding |
…sed as span attrs
albertored
force-pushed
the
include-headers-in-attrs
branch
from
9ebee53
to
fef3575
Compare
albertored
changed the title
|
@tsloughter it is now implemented for almost all HTTP clients/servers, only elli is missing because I'm not so familiar with it. |
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #183
I implemented this on top of #128 because it was more convenient for me so we should wait for merging that PR before merging this one.