-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.OpenTelemetryProtocol] Clients for profiling exporter #5759
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5759 +/- ##
==========================================
+ Coverage 83.38% 86.16% +2.78%
==========================================
Files 297 259 -38
Lines 12531 11204 -1327
==========================================
- Hits 10449 9654 -795
+ Misses 2082 1550 -532
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -4,10 +4,12 @@ | |||
using System.Runtime.CompilerServices; | |||
|
|||
#if SIGNED | |||
[assembly: InternalsVisibleTo("OpenTelemetry.AutoInstrumentation, PublicKey=00240000048000009400000006020000002400005253413100040000010001008db7c66f4ebdc6aac4196be5ce1ff4b59b020028e6dbd6e46f15aa40b3215975b92d0a8e45aba5f36114a8cb56241fbfa49f4c017e6c62197857e4e9f62451bc23d3a660e20861f95a57f23e20c77d413ad216ff1bb55f94104d4c501e32b03219d8603fb6fa73401c6ae6808c8daa61b9eaee5d2377d3c23c9ca6016c6582d8")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kielek - What all things you would need to copy if we don't do this?
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Needed for https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docs/internal/continuous-profiler.md
Changes
OpenTelemetry.AutoInstrumetnation
.Profiling is highly experimental signal, but I would like to avoid making hard copies from this project into AutoInstrumentation.
For now, I decided to create here only direct clients. The exporter itself will be implemented in AutoInstrumentation.
I think that it is good compromise between reusability and possibility to make changes easily for Auto Instrumentation needs.
In the future, when the profiling will be closed to rc/ga state,I would expect to move more code to this project (Exporter).
Will be used by open-telemetry/opentelemetry-dotnet-instrumentation#3539
Other option
Alternative option is to make changes only in internals visible to and implement everything on the auto instrumentation side.
Merge requirement checklist
[ ] AppropriateCHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)