Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messaging attributes from 1.23 to 1.28 #3765

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ysolomchenko
Copy link
Contributor

Why

What

  • Updated messaging attributes to follow the 1.28 semantic convention changes, including new attributes and revised attribute definitions.

Tests

Ci

Checklist

  • CHANGELOG.md is updated.
  • Documentation is updated.
  • New features are covered by tests.

@@ -11,6 +11,8 @@ This component adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.h

### Changed

- Update messaging attributes from [v1.23.0](https://github.com/open-telemetry/semantic-conventions/blob/v1.23.0/docs/messaging/messaging-spans.md) to [v1.28.0](https://github.com/open-telemetry/semantic-conventions/blob/v1.28.0/docs/messaging/messaging-spans.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add information that it affects Kafka and RabbitMq6 instrumentation.

@ysolomchenko
Copy link
Contributor Author

We should wait with this PR until the messaging semantic conventions stabilize.

https://github.com/open-telemetry/semantic-conventions/blob/v1.28.0/docs/messaging/messaging-spans.md

Warning

Existing messaging instrumentations that are using
v1.24.0 of this document
(or prior) SHOULD NOT change the version of the messaging conventions that they emit by default
until a transition plan to the (future) stable semantic conventions has been published.
Conventions include, but are not limited to, attributes, metric and span names, and unit of measure.

@zacharycmontoya
Copy link
Contributor

SIG: It was advised that we wait until messaging attributes semantic conventions are stabilized before doing this update, this may stay in draft or be closed until such time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants