Update usage of ABI 2 to match breaking changes in opentelemetry-cpp v1.16.0 release #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
justin-mccann
commented
Jul 13, 2024
justin-mccann
commented
justin-mccann
force-pushed
the
fixups_for_otel_cpp_v1_16_0
branch
from
ff8e7aa
to
929d405
Compare
|
Apologies for the churn; I was following code from the relevant v1.16.0 changes and am also seeing some discrepancies between build environments. |
justin-mccann
force-pushed
the
fixups_for_otel_cpp_v1_16_0
branch
from
929d405
to
e846291
Compare
…v1.16.0 release. See https://github.com/open-telemetry/opentelemetry-cpp/blob/v1.16.0/CHANGELOG.md#1160-2024-06-21 for details on the v1.16.0 changes. Fixes open-telemetry#465.
justin-mccann
force-pushed
the
fixups_for_otel_cpp_v1_16_0
branch
from
e846291
to
4afbfd6
Compare
|
The Centos7 check is failing because of issue #461. Maybe we should disable it until a new platform target is chosen. |
|
@kpratyus, @DebajitDas #461 is blocker for now. Should we disable the relevant centos7 CI test to let other PRs get merged? |
|
@svrnm The CI for webserver instrumentation has been failing for a long time now. Can you help check with @kpratyus / @DebajitDas if they can fix it soon :) Thanks. |
|
@aryanishan1001 please take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.