feat: executor to manage its own networks #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/http.php
Outdated
| try { | ||
| $orchestration->remove($container->getId(), true); | ||
|
|
||
| $activeRuntimeId = $container->getName(); | ||
|
|
||
| if (!$activeRuntimes->exists($activeRuntimeId)) { | ||
| if ($activeRuntimes->exists($activeRuntimeId)) { |
There was a problem hiding this comment.
Previously it was !$activeRuntimes->exists. Was that a bug?
There was a problem hiding this comment.
I think its a bug.. because if the activeRuntimeId does not exist in the swoole table, how can we delete it?
But Ive reverted it since I want to validate with matej
composer.json
Outdated
| @@ -35,7 +35,7 @@ | |||
| "utopia-php/registry": "0.5.*", | |||
| "utopia-php/preloader": "0.2.*", | |||
| "utopia-php/system": "0.8.*", | |||
| "utopia-php/orchestration": "0.13.*", | |||
| "utopia-php/orchestration": "dev-add-network-exists", | |||
There was a problem hiding this comment.
You'd update this, right?
feat: adjusting table size
feat: getting executor name
feat: executor to manage its own networks
…se-bridge-networks
abnegate
approved these changes
Aug 30, 2024
vermakhushboo
approved these changes
Aug 30, 2024
TorstenDittmann
approved these changes
Aug 30, 2024
byawitz
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.