feat: retry and uniqid #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
reviewed
Oct 29, 2024
| @@ -490,7 +490,7 @@ function cleanUp(Orchestration $orchestration, Table $activeRuntimes, array $net | |||
| ->action(function (string $runtimeId, string $image, string $entrypoint, string $source, string $destination, string $outputDirectory, array $variables, string $runtimeEntrypoint, string $command, int $timeout, bool $remove, float $cpus, int $memory, string $version, string $restartPolicy, array $networks, Orchestration $orchestration, Table $activeRuntimes, Response $response, Log $log) { | |||
| $runtimeName = System::getHostname() . '-' . $runtimeId; | |||
|
|
|||
| $runtimeHostname = \uniqid(); | |||
There was a problem hiding this comment.
Lets check for more occurances, I think I saw multiplr
There was a problem hiding this comment.
There is one more usage in the build path name, but I don't think it's an issue with collision / or worth increasing the scope of this PR to address immediate function errors
Meldiron
reviewed
Oct 29, 2024
Meldiron
reviewed
Oct 29, 2024
christyjacob4
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\bin2hex(\random_bytes(16))instead of\uniqid()for a more unique and secure identifier.activeRuntimeextra to sentry to aid debuggingCURLE_COULDNT_RESOLVE_HOST(6), andCURLE_COULDNT_CONNECT(7). The loop retries until successful or until the timeout is reached.