Merge pull request #206 from open-pv/169-tiles-caching

Terrain toggle now only hides terrain tiles instead of destroying them
open-pv · Aug 22, 2024 · 7febe65 · 7febe65
2 parents 54bb877 + 31edae5
commit 7febe65
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/components/ThreeViewer/Scene.js b/src/components/ThreeViewer/Scene.js
@@ -79,7 +79,7 @@ const Scene = ({
         setPVPoints={setPVPoints}
       />
 
-      {simulationMesh != undefined && showTerrain && <Terrain />}
+      {simulationMesh != undefined && <Terrain visible={showTerrain}/>}
     </Canvas>
   )
 }

diff --git a/src/components/ThreeViewer/Terrain.js b/src/components/ThreeViewer/Terrain.js
@@ -108,7 +108,7 @@ const TerrainTile = (props) => {
   return mesh
 }
 
-const Terrain = () => {
+const Terrain = ({visible}) => {
   const [x, y] = coordinatesXY15
   let tiles = []
   const tx = Math.floor(x * 16)
@@ -127,7 +127,11 @@ const Terrain = () => {
     tiles.push(<TerrainTile key={key} x={tx + dx} y={ty + dy} zoom={19} />)
   }
 
-  return <>{tiles}</>
+  console.log(`Terrain visible:`)
+  console.log(visible);
+  return <group visible={visible}>
+    {tiles}
+  </group>
 }
 
 export default Terrain