chore: Bump GATOR_VERSION to 1.17.0 from 1.16.3 #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 1.17.0 version of gator (which I've been using on my machine), the `--experimental-enable-k8s-native-validation` flag has been renamed to `--enable-k8s-native-validation`. This was preventing me from using the `make verify-gator` target. This PR fixes updates the GATOR_VERSION and changes the flag. Signed-off-by: juliankatz <[email protected]>
|
@julianKatz - Probably want to bump to match? |
|
@apeabody correct, we'll need to support both --experimental and non-experimental flags since we support 2 versions |
| @@ -50,17 +50,17 @@ test-integration: | |||
| .PHONY: verify-gator | |||
| verify-gator: | |||
| ifeq ($(POLICY_ENGINE), rego) | |||
| gator verify ./... --experimental-enable-k8s-native-validation=false | |||
| gator verify ./... --enable-k8s-native-validation=false | |||
There was a problem hiding this comment.
We need a conditional check here for GATOR_VERSION, for < 3.17 use experimental flag, for >= 3.17 use updated flag.
|
This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
|
@julianKatz Are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 1.17.0 version of gator (which I've been using on my machine), the
--experimental-enable-k8s-native-validationflag has been renamed to--enable-k8s-native-validation. This was preventing me from using themake verify-gatortarget.This PR fixes updates the GATOR_VERSION and changes the flag.