Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Init teacher weight by default #452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

twmht
Copy link
Contributor

@twmht twmht commented Feb 7, 2023

Init teacher weight by default

Motivation

Before this PR, we can only load the weight of teacher if we provide teacher_ckpt. And we can't specify the map_location to cpu if we use teacher_ckpt, this would cost huge gpu memory in the first gpu.

By the way, i did not find any reason to provide teacher_ckpt if we have provided the init_cfg to the teacher, can we force users to use only init_cfg?

Modification

init teacher weight by default

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@twmht twmht changed the title [Improvement] Init teacher weight if not providing teacher_ckpt [Improvement] Init teacher weight by default Feb 7, 2023
Init teacher weight by default
@pppppM pppppM requested a review from HIT-cwh March 1, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant