-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(evaluator): calculate average of metric result across all dataset #1947
base: main
Are you sure you want to change the base?
feat(evaluator): calculate average of metric result across all dataset #1947
Conversation
Sharad Sirsat seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
3f37077
to
b68dba4
Compare
@Harold-lkk I have made changes as per my requirement, please review and comment. Let me know if there is anything else. |
Hi @serious-gist, We'd like to express our appreciation for your valuable contributions to the mmocr. Your efforts have significantly aided in enhancing the project's quality. If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID". Thanks again for your awesome contribution, and we're excited to have you as part of our community! |
Hi, thanks for your contribution! Before we are able to merge your PR, please don't forget to sign CLA here :) Also, if you get an error message like "xxx seems not to be a GitHub user", it means that the email you used to commit changes does not match the one you used in your GitHub account. You can try to link your local email to your GitHub, or update your local email address and then amend your commits: git config --global user.email "YOUR_GITHUB_EMAIL"
git commit --amend |
if is_main_process(): | ||
metrics_results = [metrics_results] | ||
averaged_results = self.average_results(metrics_results) | ||
else: | ||
metrics_results = [None] # type: ignore | ||
averaged_results = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metrics_results need to process like this
broadcast_object_list(metrics_results) | ||
broadcast_object_list([averaged_results]) | ||
|
||
return metrics_results[0], averaged_results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return should be a single dict.
d3b2e4f
to
6faeb6f
Compare
Issue
Currently mmocr does not returns the avergae of all metric results in MultiDatasetEvaluator
Solution
Adding an method which calculates the average of all the metric results.
How to tackle this PR.
Just go through the changes made and test cases that are added.