Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

courses: smoother deletion snackbar (fixes #7941) #7953

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

courses: smoother deletion snackbar (fixes #7941) #7953

wants to merge 3 commits into from

Conversation

Gavinp14
Copy link
Member

@Gavinp14 Gavinp14 commented Dec 17, 2024 •
edited
Loading

fixes #7941

@Gavinp14 Gavinp14 linked an issue Dec 17, 2024 that may be closed by this pull request
courses: long non-spaced titles on snack bar #7941
Open
jessewashburn
jessewashburn requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@jessewashburn jessewashburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this will truncate not just the title, but the information following it. E.G if you join a course, you would want it to say "aaaaaaaaa.... added to your dashboard" not just "aaaaaaaaaaa..." The universal approach may not work after all.

image

@Gavinp14
Copy link
Member Author

I see I will make this change just for the courses snack bar instead

@Gavinp14 Gavinp14 changed the title courses: smoother snackbar (fixes #7941) courses: smoother deletion snackbar (fixes #7941) Dec 17, 2024
@Gavinp14 Gavinp14 requested a review from RheuX December 17, 2024 19:17
RheuX
RheuX reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@RheuX RheuX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it supposed to like this? or is it supposed to be truncated?

image

image

@Gavinp14
Copy link
Member Author

hmmm, it does not do this for my screen. @Mutugiii could you check this pr out on your side to see if anything is wrong?

@jessewashburn
Copy link
Member

is it supposed to like this? or is it supposed to be truncated?

It's because the change for this PR is only related to the course deletion snackbar. For adding/removing courses to/from myLibrary, that's related to the courses.service.ts, similar to PR #7956

@Mutugiii
Copy link
Member

@Gavinp14 Getting a similar issue to that of @RheuX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RheuX RheuX RheuX left review comments

@jessewashburn jessewashburn jessewashburn approved these changes

Assignees
No one assigned
Labels
Review requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

courses: long non-spaced titles on snack bar
4 participants
@Gavinp14 @jessewashburn @Mutugiii @RheuX