feedback: smoother name (fixes #7892, #7963, #7965) #7907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gavinp14
approved these changes
Dec 9, 2024
RheuX
reviewed
Dec 10, 2024
There was a problem hiding this comment.
@jessewashburn for some reason, i cant seem to see the changes you made, could you provide a video on how you test this? even my feedback is not truncated thats why im very confused.
I'm pretty sure the branch is the most up to date.
|
Since everything it is titled by the page name we could as well title the home by the page name for uniformity. |
|
Seems one of my changes may have gotten reverted. I will correct and ping for re-review. |
jessewashburn
changed the title
Gavinp14
approved these changes
Dec 19, 2024
jessewashburn
changed the title
Gavinp14
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7892, #7963, #7965
I opted to move the truncation to the front end, in order to maintain the titles and urls on couchdb. Added some responsive styling to both feedback pages.