Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Secure Password Criteria (fixes #6768) #7846

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gavinp14
Copy link
Member

Will Not let you create an account unless the password meets the following criteria

  • Minimum 8 characters long
  • Must contain at least one number
  • Must contain at least one special character

This is something that should be up for discussion, so please comment and leave some thoughts on the password criteria and if it should be adjusted.

weakpass

@Gavinp14 Gavinp14 requested a review from Mutugiii November 27, 2024 16:44
@Gavinp14 Gavinp14 linked an issue Nov 27, 2024 that may be closed by this pull request
@jessewashburn
Copy link
Member

I think this is a great suggestion. Users could potentially be keeping sensitive health and financial information on the app, so I think security is definitely a concern.

Only suggestion would be a more a descriptive message about what the password criteria is, but this is already in line with how a lot of other apps handle this.

@Gavinp14
Copy link
Member Author

I agree Jesse, I am going to edit the error message, so it displays the password criteria.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password: Security Issue
3 participants