Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mi-10-steps.md (fixes #3523) #3526

Closed
wants to merge 5 commits into from

Conversation

Daunt-99
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action.

Before Creating the Pull Request

  • Verify the changes are on a new branch other than master – it should say "compare: branch-name".
  • Start the pull request title with lowercase letters, e.g., add githubusername.md.
  • Add issue number to the end of the pull request title when applicable, e.g., update mi-faq.md (fixes #3264).

After Creating the Pull Request

  • Go to "Commits" tab, make sure the commit username is clickable and linked to your GitHub account correctly.
  • Review the "Files changed" tab to ensure there are no unnecessary files or changes included in the pull request.
  • Verify that the raw.githack preview link is included in the description.
    • Preview the MDwiki rendered changes using the raw.githack link. Ensure it displays as expected without any errors.
  • Drop a link to this pull request in our discord channel.

Description, Screenshots and/or Screencast

Made step 2 easier to understand with bullet points for clarification and also moved step 2 to a different page.

fixes #3523

Raw.Githack Preview Link

https://raw.githack.com/Daunt-99/Daunt-99.github.io/update-step2/index.html#!pages/mi/mi-10-steps.md

@@ -108,7 +89,7 @@ Follow the guide at [Create More Issues and Pull Requests](mi-issues-and-prs.md)

## Step 9 - Kotlin Tour

myPlanet use Kotlin as the development language. If you have no or little prior exposure to Kotlin, please go over the [Kotlin crash-course](https://developer.android.com/kotlin/learn) on Android Developers to gain some familiarity.
myPlanet uses Kotlin as the development language. If you have no or little prior exposure to Kotlin, please go over the [Kotlin crash-course](https://developer.android.com/kotlin/learn) on Android Developers to gain some familiarity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you created the branch update-step2 from 3515-fix-typo. Please ensure you follow the steps outlined at Synchronize Your Repository to fetch changes from upstream into your master branch first. Then, create a new branch for your new issue.

Typically, branches should be created from master, unless there's a specific reason—such as working on a feature in 3515-fix-typo where someone is stuck, and you decide to help by continuing from their branch.

Another issue I noticed from the Commits tab is that all commits were created using the GitHub web interface. While many of the changes in First Steps involve simple text edits, we also want to see that you can work with Git in the terminal. This is important because, as an intern, you’ll likely need to work on code and test locally beyond what the GitHub interface allows.

Given this, please follow the steps outlined in Synchronize Your Repository to rework this pull request using the terminal/git bash.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thank you.

@xyb994 xyb994 closed this Dec 23, 2024
@Daunt-99 Daunt-99 deleted the update-step2 branch December 23, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update clarity and structure of step 2 in mi-10-steps.md
2 participants