myCourses: smoother button styling (fixes #4925) #4926
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avinash-Codes
approved these changes
Jan 1, 2025
Okuro3499
requested changes
Jan 2, 2025
Comment on lines
20
to
21
| <stroke android:width="1dp" android:color="@color/colorPrimary" /> | ||
| <gradient android:angle="-90" android:endColor="@color/colorPrimary" android:startColor="@color/colorPrimary" /> |
There was a problem hiding this comment.
we try to maintain the app's blue theme in both dark and light mode. This change gives the button a black background in dark mode which is not what we want
There was a problem hiding this comment.
So the changes are matching the lightmode, where the leave button follows the same theme as the section banner
There was a problem hiding this comment.
In darkmode the button should still be blue as it is currently on master
Button color reverted but align components persist
|
Okuro3499
requested changes
Jan 9, 2025
There was a problem hiding this comment.
I don't see any difference between the screenshot in the issue #4925 (comment) and the courses page in this pr
|
Hi @Okuro3499 , the buttons are now aligned and of the same size
|
Okuro3499
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
leave light mode.webm
leave button darkmode.webm