all: smoother orientation change (fixes #4859) #4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okuro3499
requested changes
Dec 13, 2024
There was a problem hiding this comment.
if the device theme is set to light mode and the app dark theme is set to "follow system" rotating after setting the to dark theme rotating the screen does not remember the user choice and resets back to follow system
Screen_recording_20241213_133304.webm
|
Hi @Okuro3499 checkout the below tests for this PR
system.darkmode.app.theme.changes.mp4
system.light.app.changes.mp4 |
Okuro3499
approved these changes
Dec 18, 2024
Avinash-Codes
approved these changes
Dec 18, 2024
dogi
approved these changes
Dec 18, 2024
dogi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Video
changing.orientation.with.darkmode.webm