Skip to content

Commit

Permalink
profile: accessibility enhancements (fixes #2632) (#2635)
Browse files Browse the repository at this point in the history
Co-authored-by: dogi <[email protected]>
  • Loading branch information
Okuro3499 and dogi authored Oct 25, 2023
1 parent 88bb8c6 commit cd93801
Show file tree
Hide file tree
Showing 10 changed files with 21 additions and 4 deletions.
4 changes: 2 additions & 2 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ android {
applicationId "org.ole.planet.myplanet"
minSdkVersion 21
targetSdkVersion 34
versionCode 1112
versionName "0.11.12"
versionCode 1113
versionName "0.11.13"
ndkVersion '21.3.6528147'
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
vectorDrawables.useSupportLibrary = true
Expand Down
6 changes: 6 additions & 0 deletions app/src/main/res/layout/activity_become_member.xml
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@
android:layout_height="wrap_content"
android:background="@drawable/border"
android:entries="@array/language"
android:contentDescription="@string/language"
android:padding="@dimen/padding_normal" />

</LinearLayout>
Expand Down Expand Up @@ -221,12 +222,14 @@
android:id="@+id/male"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:contentDescription="@string/male"
android:text="@string/male" />

<RadioButton
android:id="@+id/female"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:contentDescription="@string/female"
android:text="@string/female" />


Expand Down Expand Up @@ -259,6 +262,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:entries="@array/level"
android:contentDescription="@string/level"
android:padding="@dimen/padding_small" />
</RelativeLayout>
</LinearLayout>
Expand All @@ -274,6 +278,7 @@
style="@style/Widget.MaterialComponents.Button.TextButton"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:contentDescription="@string/button_cancel"
android:text="@string/button_cancel"
android:textSize="@dimen/text_size_mid"
android:textStyle="bold" />
Expand All @@ -284,6 +289,7 @@
android:layout_height="wrap_content"
android:text="@string/become_a_member"
android:textSize="@dimen/text_size_mid"
android:contentDescription="@string/become_a_member"
android:theme="@style/FocusButton" />


Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/layout/fragment_achievement.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
android:drawableStart="@drawable/ic_edit"
android:drawablePadding="@dimen/padding_normal"
android:padding="@dimen/padding_normal"
android:contentDescription="@string/edit_achievement"
android:text="@string/edit_achievement" />


Expand Down
8 changes: 6 additions & 2 deletions app/src/main/res/layout/fragment_edit_achievement.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
android:layout_height="wrap_content"
android:drawableLeft="@drawable/ic_edit"
android:drawablePadding="@dimen/padding_normal"
android:contentDescription="@string/edit_achievement"
android:padding="@dimen/padding_normal"
android:text="@string/edit_achievement" />

Expand Down Expand Up @@ -209,6 +210,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:padding="@dimen/padding_normal"
android:contentDescription="@string/add_an_achievement"
android:text="@string/add_an_achievement"
android:theme="@style/PrimaryButton" />

Expand All @@ -230,7 +232,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:padding="@dimen/padding_normal"

android:contentDescription="@string/add_a_reference"
android:text="@string/add_a_reference"
android:theme="@style/PrimaryButton" />

Expand All @@ -240,7 +242,7 @@
android:layout_height="wrap_content"
android:layout_gravity="center"
android:padding="@dimen/padding_normal"
android:text="Allow your achievements to be shared with the nation"
android:text="@string/send_to_nation"
android:textSize="@dimen/text_size_large" />

<LinearLayout
Expand All @@ -252,13 +254,15 @@
android:id="@+id/btn_update"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:contentDescription="@string/button_update"
android:text="@string/button_update"
android:theme="@style/PrimaryButton" />

<Button
android:id="@+id/btn_cancel"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:contentDescription="@string/button_cancel"
android:text="@string/button_cancel"
android:theme="@style/AccentButton" />

Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values-ar/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -947,5 +947,6 @@
<string name="request_failed_please_retry">الطلب فشل، يرجى إعادة المحاولة</string>
<string name="confirm_removal">تأكيد الحذف</string>
<string name="returning_user">مستخدم عائد</string>
<string name="send_to_nation">اسمح بمشاركة إنجازاتك مع الوطن</string>

</resources>
1 change: 1 addition & 0 deletions app/src/main/res/values-es/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -952,5 +952,6 @@
<string name="request_failed_please_retry">La solicitud ha fallado, por favor inténtelo de nuevo</string>
<string name="confirm_removal">Confirmar eliminación</string>
<string name="returning_user">Usuario recurrente</string>
<string name="send_to_nation">Permite que tus logros se compartan con la nación</string>

</resources>
1 change: 1 addition & 0 deletions app/src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -952,5 +952,6 @@
<string name="request_failed_please_retry">La demande a échoué, veuillez réessayer</string>
<string name="confirm_removal">Confirmer la suppression</string>
<string name="returning_user">Utilisateur régulier</string>
<string name="send_to_nation">Autorisez la partage de vos réalisations avec la nation</string>

</resources>
1 change: 1 addition & 0 deletions app/src/main/res/values-ne/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -952,5 +952,6 @@
<string name="request_failed_please_retry">अनुरोध असफल भयो, कृपया पुन: प्रयास गर्नुहोस्</string>
<string name="confirm_removal">हटाउनु हेरदैछ</string>
<string name="returning_user">पुनराबृत्ति गर्ने प्रयोगकर्ता</string>
<string name="send_to_nation">तपाइको उपलब्धिहरूलाई देशसँग साझा गर्न अनुमति दिनुहोस्</string>

</resources>
1 change: 1 addition & 0 deletions app/src/main/res/values-so/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -941,5 +941,6 @@
<string name="request_failed_please_retry">Codka lama yimaado, fadlan dib ugu ciyaar</string>
<string name="confirm_removal">Xaqiiji tirtirka</string>
<string name="returning_user">Isticmaale sare leh</string>
<string name="send_to_nation">Geli codbixiyeyaashaaga qaranka</string>

</resources>
1 change: 1 addition & 0 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1042,5 +1042,6 @@
<string name="request_failed_please_retry">Request failed, please retry</string>
<string name="confirm_removal">Confirm removal</string>
<string name="returning_user">Returning user</string>
<string name="send_to_nation">Allow your achievements to be shared with the nation</string>

</resources>

0 comments on commit cd93801

Please sign in to comment.