Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recommended value for HDUCLASS in hduclass.rst #90

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

lmohrmann
Copy link
Collaborator

This request updates the recommended value for the HDUCLASS header keyword from "CTA" to "GADF" as already introduced e.g. here.

@cdeil cdeil added this to the 0.2 milestone Jul 12, 2017
@cdeil
Copy link
Member

cdeil commented Jul 12, 2017

There was quite some discussion here on what value to put for this key in the context of CTA:
cta-observatory/ctapipe#308 (comment)

It's mostly me suggesting to put "GADF" for "gamma-astro-data-formats" and @jknodlseder saying we should use OGIP.

I think when we ( @TarekHC , @cboisson, @bkhelifi ) discussed this at the DL3 f2f meeting, we agreed to put "GADF" and did that everywhere in the spec, and this one remaining mention of "CTA" is an oversight?

Just for context: @lmohrmann is updating the HESS FITS exporter, and we want to finalise this now that the HESS FITS test data release is approved, and produce files that are up to this spec.
To me "CTA" (what's mentioned there now) isn't a great choice, since this is something that existing IACTs also want to use and it's not been approved or decided on in CTA, and other places in the spec currently mention "GADF" already.

I would suggest to merge this now, and then if / when in CTA there's a DL3 group that can decide something in the coming years, the discussion on whether to put "OGIP" or "CTA" instead can continue.

@TarekHC
Copy link
Member

TarekHC commented Jul 12, 2017

I would suggest to merge this now, and then if / when in CTA there's a DL3 group that can decide something in the coming years, the discussion on whether to put "OGIP" or "CTA" instead can continue.

I'm ok with this change. In fact, in every IRF described, we suggest to use the "GADF", so probably this line was simply missing to be updated.

So I would not re-open the discussion and directly merge it.

@cdeil cdeil merged commit 49b7478 into open-gamma-ray-astro:master Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants