🔊 [#4927] Add system check for missing allow_blank on non-required charfields

[stevenbal]

Closes #4927

Changes

• Add system check for missing allow_blank on non-required charfields

Checklist

Check off the items that are completed or not relevant.

• Impact on features

  • Checked copying a form
  • Checked import/export of a form
  • Config checks in the configuration overview admin page
  • Problem detection in the admin email digest is handled

• Release management

  • I have labelled the PR as "needs-backport" accordingly

• I have updated the translations assets (you do NOT need to provide translations)

  • Ran ./bin/makemessages_js.sh
  • Ran ./bin/compilemessages_js.sh

• Dockerfile/scripts

  • Updated the Dockerfile with the necessary scripts from the ./bin folder

• Commit hygiene

  • Commit messages refer to the relevant Github issue
  • Commit messages explain the "why" of change, not the how

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (f16d700) to head (ecea971).
Report is 21 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4989   +/-   ##
=======================================
  Coverage   96.62%   96.63%           
=======================================
  Files         761      761           
  Lines       25961    25972   +11     
  Branches     3394     3394           
=======================================
+ Hits        25084    25097   +13     
+ Misses        611      610    -1     
+ Partials      266      265    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stevenbal]

@sergei-maertens should I write a test for this check?

[sergei-maertens]

@sergei-maertens should I write a test for this check?

No, I don't think so, So you can # pragma: no cover it :)

[stevenbal]

@sergei-maertens CI fails due to https://machtigen.digid.nl being down