Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust button styling to match the ones from the LMS #146

Merged
merged 5 commits into from
May 22, 2024

Conversation

Agrendalath
Copy link
Member

@Agrendalath Agrendalath commented May 7, 2024

Description

Note: Please read the code commit-by-commit.

This:

  1. Changes the structure of the "Submit" and "View results" buttons to reuse the styling from LMS.
  2. Adds the btn-brand class to "Export results to CSV" and "Download CSV" to reuse the styling from LMS.
  3. Removes the "Submit" button from the results page, as it's redundant there. All fields and the button itself are disabled anyway.
  4. Moves the versioning to poll/__init__.py to match other XBlocks.
  5. Adds load_requirements to setup.py to use the correct requirements.
  6. Removes six usage from the XBlocks and tests.
  7. Updates xgettext-template to eliminate potential vulnerabilities.
  8. Adds support for xblock.utils (Remove xblock-utils dependency #114). Does not remove the support for xblock-utils, though.
  9. Adds the MANIFEST to correctly include files in the Python package. You can see that these flies were missing by checking that the README is not displayed in PyPi.

Screenshots

Before
After

Instructions

  1. Set up the XBlock in Studio (as described in the README) and check its basic functionality in the LMS/Preview.

Private-ref: BB-8763

@Agrendalath Agrendalath self-assigned this May 7, 2024
@Agrendalath Agrendalath force-pushed the agrendalath/bb-8763-unified-styling branch from 200ffa4 to bc1ce16 Compare May 9, 2024 00:05
@Agrendalath Agrendalath force-pushed the agrendalath/bb-8763-unified-styling branch from 2c911c2 to 1a0134e Compare May 9, 2024 00:29
@Agrendalath Agrendalath requested a review from tecoholic May 9, 2024 00:30
Copy link
Member

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looking good! Thanks for the cleanup and modernisation.

  • I tested this: tested on tutor devstack
  • I read through the code

@Agrendalath Agrendalath merged commit dc764eb into master May 22, 2024
5 checks passed
@Agrendalath Agrendalath deleted the agrendalath/bb-8763-unified-styling branch May 22, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants