Skip to content

Commit

Permalink
feat: simplify nightly version management
Browse files Browse the repository at this point in the history
By pulling the version suffix from tutor, we avoid git conflicts when
merging the release branch in nightly.
  • Loading branch information
regisb committed Nov 20, 2023
1 parent 691513b commit 54e81f4
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def load_about():

setup(
name="tutor-mfe",
version=ABOUT["__package_version__"],
version=ABOUT["__version__"],
url="https://github.com/overhangio/tutor-mfe",
project_urls={
"Code": "https://github.com/overhangio/tutor-mfe",
Expand Down
7 changes: 0 additions & 7 deletions tutormfe/__about__.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,2 @@
__version__ = "16.1.2"
__package_version__ = __version__


# Handle version suffix for nightly, just like tutor core.
__version_suffix__ = ""

if __version_suffix__:
__version__ += "-" + __version_suffix__
7 changes: 6 additions & 1 deletion tutormfe/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,18 @@

import pkg_resources
from tutor import fmt
from tutor.__about__ import __version_suffix__
from tutor import hooks as tutor_hooks
from tutor.hooks import priorities
from tutor.types import Config, get_typed

from .__about__ import __version__, __version_suffix__
from .__about__ import __version__
from .hooks import MFE_APPS, MFE_ATTRS_TYPE

# Handle version suffix in nightly mode, just like tutor core
if __version_suffix__:
__version__ += "-" + __version_suffix__

config = {
"defaults": {
"VERSION": __version__,
Expand Down

0 comments on commit 54e81f4

Please sign in to comment.