release-schema: update tag and publisher description for compiled releases #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncandewhurst
requested changes
Nov 5, 2024
schema/release-schema.json
Outdated
| @@ -27,13 +27,13 @@ | |||
| }, | |||
| "publisher": { | |||
| "title": "Publisher", | |||
| "description": "The original publisher of this release.", | |||
| "description": "The original publisher of the release. For a compiled release this may differ from the publisher(s) of the individual releases about the contracting process.", | |||
There was a problem hiding this comment.
Use non-normative synonym. Add "or planning process".
Suggested change
| "description": "The original publisher of the release. For a compiled release this may differ from the publisher(s) of the individual releases about the contracting process.", | |
| "description": "The original publisher of the release. The publisher of a compiled release for a contracting or planning process might differ from the publishers of its releases.", |
There was a problem hiding this comment.
But the schema is supposed to be normative?
Agree with the rest of the re-wording and have applied
There was a problem hiding this comment.
I think the first sentence sets the normative semantics, and the second sentence provides some additional guidance to aid interpretation. I might be wrong, though!
Co-authored-by: Duncan Dewhurst <[email protected]>
duncandewhurst
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #330