Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct links #105

Merged
merged 1 commit into from
Mar 8, 2024
Merged

correct links #105

merged 1 commit into from
Mar 8, 2024

Conversation

morri-son
Copy link
Contributor

What this PR does / why we need it:

correct links

@morri-son morri-son requested a review from robertwol March 8, 2024 14:52
@morri-son morri-son enabled auto-merge (squash) March 8, 2024 16:40
@morri-son morri-son disabled auto-merge March 8, 2024 16:40
@morri-son morri-son merged commit 15590da into main Mar 8, 2024
1 check failed
@morri-son morri-son deleted the correct-links branch March 8, 2024 16:40
@morri-son
Copy link
Contributor Author

@hilmarf , the md check brought up quite a bunch of issues and failed: https://github.com/open-component-model/ocm-spec/actions/runs/8205012914/job/22440916823?pr=105. I guess we need to adopt it a bit. Or there should be a possibility to correct the things.

@hilmarf
Copy link
Member

hilmarf commented Mar 11, 2024

@hilmarf , the md check brought up quite a bunch of issues and failed: https://github.com/open-component-model/ocm-spec/actions/runs/8205012914/job/22440916823?pr=105. I guess we need to adopt it a bit. Or there should be a possibility to correct the things.

@morri-son I would always vote first for fixing the warnings (e.g. with the help of: https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint). But if you want to skip the linting, that's fine as well. But we should definitely keep the link-checks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants