fix: allowing domain to be added including a scheme

[Skarlso]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

• 🍕 Feature
• 🐛 Bug Fix
• 📝 Documentation Update
• 🎨 Style
• 🧑‍💻 Code Refactor
• 🔥 Performance Improvements
• ✅ Test
• 🤖 Build
• 🔁 CI
• 📦 Chore (Release)
• ⏩ Revert

Related Tickets & Documents

• Related Issue # (issue)
• Closes # (issue)
• Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

• 👍 yes
• 🙅 no, because they aren't needed
• 🙋 no, because I need help
• Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

• 📜 README.md
• 🙅 no documentation needed

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[phoban01]

I think this is a better approach than adding logic that would parse the domain as a url and remove the scheme.

[Skarlso]

Aye. I had to think a lot to come up with a proper way of making sure localhost and port are still allowed but https:// is not. 🤣 since there is no negative validation. So I can't say DONT ALLOW if it contains :// or something.

[Skarlso]

I just wish I could customize the error message

ka user_repository.yaml
The Repository "new-repository-3" is invalid: spec.domain: Invalid value: "https://github.com": spec.domain in body should match '^\w+(\.|:[0-9]).*$'

But I could only do that with XValidate which is weird. :D