Group special-components by type #280
Open
+33
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocm-ci-robot-0
added
reviewed/ok-to-test
8R0WNI3
reviewed
Jan 10, 2025
src/landing.js
Outdated
| @@ -271,6 +271,14 @@ const SpecialComponents = () => { | |||
|
|
|||
| const mergedSpecialComponents = getMergedSpecialComponents(specialComponentsFeature) | |||
|
|
|||
| const specialComponentsByType = {} | |||
There was a problem hiding this comment.
Is there a reason you didn't use reduce here? I think it might be a good fit
There was a problem hiding this comment.
I agree that this could also be implemented using reduce. However, I find many reduce usages hard to comprehend already some days after implementing them.
edit:
after some considerations I will update to use reduce variant. the "complex" part (conditional object construction) is given in both variants, however using reduce will avoid mutation and be more consistent across our (mostly functional) codebase 👍
zkdev
force-pushed
the
zkdev-group-special-components
branch
from
28023a8 to
6b4cb30
Compare
ocm-ci-robot-0
added
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: