Add sql-agent to AgentQnA #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sql-agent. Add vllm as llm engine. Some value changes. Signed-off-by: Dolpher Du <[email protected]>
Signed-off-by: Dolpher Du <[email protected]>
Signed-off-by: Dolpher Du <[email protected]>
poussa
approved these changes
Jan 17, 2025
lianhao
approved these changes
Jan 17, 2025
eero-t
reviewed
Jan 17, 2025
There was a problem hiding this comment.
File names for vLLM/TGI usage are IMHO rather inconsistent with TGI+Gaudi files being named gaudi-values.yaml, and vLLM+Gaudi ones as:
helm-charts$ find -name '*vllm*.yaml'
./docsum/gaudi-vllm-values.yaml
./chatqna/gaudi-vllm-values.yaml
./agentqna/vllm-gaudi-values.yaml
./common/llm-uservice/vllm-docsum-gaudi-values.yaml
./common/llm-uservice/vllm-gaudi-values.yaml
Especially now that vLLM is becoming default in OPEA, not TGI...
I think accelerated TGI and vLLM files should be explicitly called either:
gaudi-tgi-values.yaml
gaudi-vllm-values.yaml
Or:
tgi-gaudi-values.yaml
vllm-gaudi-values.yaml
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sql-agent.
Add vllm as llm engine.
More parameters added to support latest changes.
Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.