Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename streaming to stream to align with OpenAI API #1332

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Rename streaming to stream to align with OpenAI API #1332

merged 6 commits into from
Jan 6, 2025

Conversation

XinyaoWa
Copy link
Collaborator

@XinyaoWa XinyaoWa commented Jan 2, 2025

Description

Rename streaming to stream to align with OpenAI API
Solve issue: opea-project/GenAIComps#1078
Related Comps PR: opea-project/GenAIComps#1098

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copy link

github-actions bot commented Jan 2, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@XinyaoWa
Copy link
Collaborator Author

XinyaoWa commented Jan 3, 2025

test UT in PR #1342

Signed-off-by: Xinyao Wang <[email protected]>
@XinyaoWa XinyaoWa closed this Jan 6, 2025
@XinyaoWa
Copy link
Collaborator Author

XinyaoWa commented Jan 6, 2025

test agent UT in #1350

@XinyaoWa XinyaoWa reopened this Jan 6, 2025
Signed-off-by: Xinyao Wang <[email protected]>
@chensuyue chensuyue merged commit 464e2d3 into main Jan 6, 2025
48 of 88 checks passed
@chensuyue chensuyue deleted the stream branch January 6, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants