-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Retrievers #1138
Refactor Retrievers #1138
Conversation
Signed-off-by: letonghan <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Related PR to fix GenAIExamples issues: opea-project/GenAIExamples#1387 |
Signed-off-by: letonghan <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
…/GenAIComps into refactor_retrievers
Signed-off-by: letonghan <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
…/GenAIComps into refactor_retrievers
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
for more information, see https://pre-commit.ci
@letonghan looks like this refactor completely deleted the neo4j llama-index retriever comps/retrievers/neo4j/llama_index/retriever_community_answers_neo4j.py that is needed for GraphRAG example. This retriever is different from the langchain one in functionality. This retriever is specific for GraphRAG following the microsoft Graphrag pipeline (it retrieves community summaries from neo4j graphDB and generates partial query answers that are later consolidated by final LLM in final response) |
Hi @rbrugaro . Thanks for your comment. Since the GraphRAG example depends on llama_index version of neo4j retrievers, I will refactor it and make sure it doesn't impact the examples. |
Signed-off-by: letonghan <[email protected]>
…/GenAIComps into refactor_retrievers
…o refactor_retrievers
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
…/GenAIComps into refactor_retrievers
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
…o refactor_retrievers
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
@letonghan neo4j yaml is still missing in docker_compose folder |
@letonghan the retriever_neo4j test passed but seems the telemetry traces endpoint 4318 didn't connect: https://github.com/opea-project/GenAIComps/actions/runs/12788252024/job/35649181305?pr=1138#step:4:4037 |
Signed-off-by: letonghan <[email protected]>
…o refactor_retrievers
for more information, see https://pre-commit.ci
Thanks @rbrugaro, the missing docker compose yaml files are added now. |
|
Delete redundant retrievers docker image in docker_images_list.md. Refactor Retrievers related Examples READMEs. Change all of the comps/retrievers/xxx/xxx/Dockerfile path into comps/retrievers/src/Dockerfile. Fix the Examples CI issues of PR opea-project/GenAIComps#1138. Signed-off-by: letonghan <[email protected]>
Description
Refactor retrievers into E-RAG style.
The folder structure after refactored is as below:
Issues
#1004
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
In
requirements.txt
Tests
Local tested