-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor web retriever #1102
Refactor web retriever #1102
Conversation
for more information, see https://pre-commit.ci
…ea-project/GenAIComps into source/refactor_web_retriever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR could be described more in detail what it's refactoring, as commit descriptions are also missing.
This seems to be splitting retriever_chroma.py
to:
opea_google_search.py
backend, andopea_web_retrievers_microservice.py
frontend
I assume split is done to prepare for using other search engines than Google.
Frontend is still hard-coded to using Chroma vector-db and TEI embedding, but I assume vLLM embedding support will be addded in future.
On quick look at the new code, it seems to correspond to old one, and the text & script changes look OK (git grep
does not return other matches for chroma
).
PS. IMHO opea_
prefixes for the new files are redundant as this whole thing is OPEA project / repository.
CI test "web_retrievers_opea_google_search, intel_cpu":
There are also other 2 trivial CI failures. |
…ea-project/GenAIComps into source/refactor_web_retriever
Description
Refactor web retriever
Issues
#1010
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
na
Tests
UT