-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor text2sql based on ERAG #1080
Conversation
Signed-off-by: Yao, Qing <[email protected]> (cherry picked from commit 24ef5aa)
Signed-off-by: Yao, Qing <[email protected]>
Signed-off-by: Yao, Qing <[email protected]>
Signed-off-by: Yao, Qing <[email protected]>
Signed-off-by: Yao, Qing <[email protected]>
Signed-off-by: Yao, Qing <[email protected]>
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Signed-off-by: Yao, Qing <[email protected]>
b8ddd90
to
8dd9aaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to unify all of the texttosql
to text2sql
, to align with text2img
, img2img
, and img2video
.
Signed-off-by: Yao, Qing <[email protected]>
I tried to replace it and found that there are many places globally that involve this name, and there are also many cases where capitalization is mixed. I am worried that there may be some code or docs cannot be covered by testing after the change. I suggest that we temporarily keep this name. |
I think we can update, the impact mostly belong to the service itself, it won't impact others. |
Signed-off-by: Yao, Qing <[email protected]>
Signed-off-by: Yao, Qing <[email protected]>
Description
Refactor text2sql based on ERAG
Issues
[Feature] ERAG refactor - texttosql
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Have passed comps/text2sql UT on my local environment.