Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor text2sql based on ERAG #1080

Merged
merged 13 commits into from
Jan 2, 2025
Merged

Refactor text2sql based on ERAG #1080

merged 13 commits into from
Jan 2, 2025

Conversation

yao531441
Copy link
Collaborator

Description

Refactor text2sql based on ERAG

Issues

[Feature] ERAG refactor - texttosql

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ *] New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

Have passed comps/text2sql UT on my local environment.

Signed-off-by: Yao, Qing <[email protected]>
(cherry picked from commit 24ef5aa)
Signed-off-by: Yao, Qing <[email protected]>
Signed-off-by: Yao, Qing <[email protected]>
Signed-off-by: Yao, Qing <[email protected]>
Signed-off-by: Yao, Qing <[email protected]>
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
comps/cores/mega/constants.py 96.87% <100.00%> (+0.04%) ⬆️

Signed-off-by: Yao, Qing <[email protected]>
Copy link
Collaborator

@letonghan letonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to unify all of the texttosql to text2sql, to align with text2img, img2img, and img2video.

@yao531441
Copy link
Collaborator Author

It's better to unify all of the texttosql to text2sql, to align with text2img, img2img, and img2video.

I tried to replace it and found that there are many places globally that involve this name, and there are also many cases where capitalization is mixed. I am worried that there may be some code or docs cannot be covered by testing after the change. I suggest that we temporarily keep this name.

@chensuyue
Copy link
Collaborator

It's better to unify all of the texttosql to text2sql, to align with text2img, img2img, and img2video.

I tried to replace it and found that there are many places globally that involve this name, and there are also many cases where capitalization is mixed. I am worried that there may be some code or docs cannot be covered by testing after the change. I suggest that we temporarily keep this name.

I think we can update, the impact mostly belong to the service itself, it won't impact others.

@chensuyue chensuyue merged commit 2cfd014 into main Jan 2, 2025
19 of 20 checks passed
@chensuyue chensuyue deleted the yao531441/text2sql branch January 2, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants