-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using cloudflare-ech.com as the target for the ech test #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update TLSHandshake model to include ECHConfig field * Update tests
For updates to the spec see: ooni/spec#297 |
* Add extra handshake that uses a different outer SNI field
4 tasks
DecFox
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
hellais
added a commit
to ooni/spec
that referenced
this pull request
Nov 20, 2024
## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/spec/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: <!-- add URL here --> - [x] related ooni/probe-cli pull request: ooni/probe-cli#1658 - [x] If I changed a spec, I also bumped its version number and/or date <!-- Location of the issue tracker: https://github.com/ooni/probe --> ## Description Please, insert here a more detailed description.
hellais
added a commit
that referenced
this pull request
Jan 6, 2025
* 'master' of github.com:ooni/probe-cli: Add support for returning measurement_uid as part of oonimkall API (#1673) fix(echcheck): bump version number in tests (#1671) chore: we are now hacking on 3.25.0-alpha (#1670) fix: dnscheck default input test (#1669) chore: update assets and definitions (#1665) fix: update cdeps version for mobile tests (#1668) fix: reset go version to 1.21 (#1666) chore: upgrade C dependencies (#1664) chore: upgrade dependencies (#1663) chore: upgrade android NDKVERSION (#1662) chore: upgrade GOVERSION to go1.22.2 (#1661) chore: upgrade psiphon to latest staging-client commit (#1659) feat: add fallback domain names for openvpn experiment (#1654) Simplify the dnscheck list (#1656) refactor(oonimkall): expose the session close call (#1657) Switch to using cloudflare-ech.com as the target for the ech test (#1658) Fix missing enabledByDefault in echcheck (#1655)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Changes to the ECHCheck experiment.