refactor(oonimeasurements): redesign measurements service #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Align the queries to be closer to original implementation
* reformat
hellais
added a commit
that referenced
this pull request
Jan 8, 2025
* init measurements refactor * refactor: measurement partial * Remove the SQLAlchemy models for fastpath tables * Align the queries to be closer to original implementation * Rename migration files so that they are applied in correct order * Fix typing of measurement_uid * Add more debug info when migrations fail * Start fixing some of the tests * Use random port for clickhouse * reformat * More progress on fixing broken tests * Fix all the tests * Remove duplicate test_measurements from tests --------- Co-authored-by: Arturo Filastò <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff refactors the measurements service to redesign using
clickhouse-sqlalchemyand also with passing tests.