Module refactor #815
Merged
Module refactor #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's missing:
|
Thanks to @DecFox for spotting it
hellais
added a commit
that referenced
this pull request
Mar 12, 2024
The main things this achieves are the following: * Switch to using hatch for dependency management instead of poetry * Create a more robust directory structure for the project * Implement a re-usable pattern for creating new services trying to minimize boilerplate to the extent possible * Add basic Readme * Promote new ooniapi to the top level directory tree More detailed changelog: * Setup tests to run against real postgresql instance instead of sqlite * Move into monorepo structure for ooniapi * Setup monorepo structure for oonirun * Add proper fix for timezone issues and update tests * Fix running of tests * Refactor build workflow with make * Promote ooniapi to the root of the repo * Fix uppercase * Fix uppercase * Fix tests * Fix image name Thanks to @DecFox for spotting it * Fix variables in codepipeline buildspec * Build the imagedefinitions in a single step
hellais
added a commit
that referenced
this pull request
Mar 12, 2024
The main things this achieves are the following: * Switch to using hatch for dependency management instead of poetry * Create a more robust directory structure for the project * Implement a re-usable pattern for creating new services trying to minimize boilerplate to the extent possible * Add basic Readme * Promote new ooniapi to the top level directory tree More detailed changelog: * Setup tests to run against real postgresql instance instead of sqlite * Move into monorepo structure for ooniapi * Setup monorepo structure for oonirun * Add proper fix for timezone issues and update tests * Fix running of tests * Refactor build workflow with make * Promote ooniapi to the root of the repo * Fix uppercase * Fix uppercase * Fix tests * Fix image name Thanks to @DecFox for spotting it * Fix variables in codepipeline buildspec * Build the imagedefinitions in a single step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this PR based on top of oonirunv2-improvements branch I implement the new pattern for building microservices in the new ooni api.
The main things it achieves are the following:
hatchfor dependency management instead ofpoetryooniapito the top level directory tree