Setting of ID in creation is optional

ooni · Oct 11, 2024 · 6328f79 · 6328f79
1 parent fd6dc5c
commit 6328f79
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/ooniapi/services/oonifindings/src/oonifindings/routers/v1.py b/ooniapi/services/oonifindings/src/oonifindings/routers/v1.py
@@ -35,7 +35,7 @@ def utcnow_seconds():
 
 
 class OONIFindingId(BaseModel):
-    incident_id: str = Field(alias="id")
+    incident_id: Optional[str] = Field(alias="id", default=None)
 
 
 class OONIFindingWithMail(OONIFindingId):
@@ -493,10 +493,6 @@ def delete_oonifinding(
     return {}
 
 
-class OONIFindingsPublish(BaseModel):
-    id: str = Field(title="ID of the finding")
-
-
 @router.post(
     "/v1/incidents/{action}",
     tags=["oonifindings"],
@@ -505,7 +501,7 @@ class OONIFindingsPublish(BaseModel):
 )
 def update_oonifinding_publish_status(
     action: str,
-    publish_request: OONIFindingsPublish,
+    publish_request: OONIFindingId,
     response: Response,
     db=Depends(get_postgresql_session),
 ):
@@ -516,7 +512,7 @@ def update_oonifinding_publish_status(
         raise HTTPException(status_code=400, detail="Invalid query action")
 
     assert publish_request
-    finding_id = publish_request.id
+    finding_id = publish_request.incident_id
 
     q = db.query(models.OONIFinding).filter(models.OONIFinding.finding_id == finding_id)
 

diff --git a/ooniapi/services/oonifindings/tests/test_oonifindings.py b/ooniapi/services/oonifindings/tests/test_oonifindings.py
@@ -18,7 +18,6 @@
 SAMPLE_EMAIL = "[email protected]"
 
 SAMPLE_OONIFINDING = {
-    "id": "",
     "title": "sample oonifinding",
     "short_description": "sample oonifinding description",
     "reported_by": "sample user",