Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor tenant ID improvements #2850

Merged
merged 13 commits into from
Oct 21, 2024
Merged

Minor tenant ID improvements #2850

merged 13 commits into from
Oct 21, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Oct 18, 2024 •
edited
Loading

Description

Minor improvements to tenant ID handling

  • Ensure we set context in background processes when connectors / dynamic configs need it
  • Move tenant ID retrieval logic to db engine

@vercel Vercel
Copy link

vercel bot commented Oct 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 11:33pm

@pablonyx pablonyx marked this pull request as ready for review October 18, 2024 20:22
@pablonyx pablonyx changed the title Migration service Minor tenant ID improvements Oct 19, 2024
yuhongsun96
yuhongsun96 approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can we add a comment on how the Slack clients work with threads which is how we know multiple requests from different Slack workspaces won't interfere with each other?

backend/danswer/danswerbot/slack/listener.py Show resolved Hide resolved
@pablonyx pablonyx added this pull request to the merge queue Oct 20, 2024
@pablonyx pablonyx removed this pull request from the merge queue due to a manual request Oct 20, 2024
@pablonyx pablonyx enabled auto-merge October 20, 2024 23:31
@pablonyx pablonyx added this pull request to the merge queue Oct 20, 2024
Merged via the queue into main with commit a24b465 Oct 21, 2024
7 checks passed
This was referenced Nov 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhongsun96 yuhongsun96 yuhongsun96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablonyx @yuhongsun96