Delay reloading tournament when saving edits #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the tournament director clicks "Save Tournament" after making edits, when they're accepted by the server, the server will send a PUSH notification on the tournament channel asking all clients to reload before sending back "success". Delay this reloading action until we have a response from the "Save" request. Previously, the reload was aborting the about-to-succeed request, kicking the client back into edit mode. Fixes online-go#2571
|
Uffizzi Preview |
dexonsmith
commented
Feb 9, 2024
| @@ -129,6 +129,8 @@ interface TournamentInterface { | |||
| opengotha_standings?: boolean; | |||
| } | |||
|
|
|||
| type EditSaveState = "none" | "saving" | "reload"; | |||
There was a problem hiding this comment.
Not sure this is really providing any type safety benefit when using React's useState. Is there some way to declare a type in useState that I missed?
There was a problem hiding this comment.
Yep like this: React.useState<EditSaveState>("none")
There was a problem hiding this comment.
(Once that's in you shouldn't nee dto do any of the "as EditSaveState" stuff in either the useState call or the setEditSaveState)
There was a problem hiding this comment.
Yeah, and there are examples of that nearby too... done in 3cb14c6.
Just in case `resolve()` somehow gets interrupted, call
`setEditSaveState("none")` first to be sure we're not left in a weird state.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tournament director clicks "Save Tournament" after making edits, when they're accepted by the server, the server will send a PUSH notification on the tournament channel asking all clients to reload before sending back "success".
Delay this reloading action until we have a response from the "Save" request. Previously, the reload was aborting the about-to-succeed request, kicking the client back into edit mode.
Fixes #2571