Switch to Fetch based requests, get rid of %% based url templates #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uffizzi Ephemeral Environment
|
anoek
force-pushed
the
fetch_based_requests
branch
from
9285dff to
5c0d92d
Compare
anoek
force-pushed
the
fetch_based_requests
branch
from
97154f5 to
dc7a357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch overhauls our
requestsutility functions in two ways:We've moved away from using jQuery's XHRHttpRequest wrapper to using the now standard fetch API.
We've moved away from using the
%%as an ID place holder in our URLs. The original purpose of the change to%%was to enable typing of our http requests (the change predated typescript's template literal types that would have obviated that change), however there was never any follow-through on that and now with the advancements in typescript we can achieve typing without the need to have the%%placeholders anyways, so this PR makes the change back to the clearer less error prone string template style of specifying URLs.